Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented separated matched data for different locaitons #453

Merged
merged 2 commits into from Oct 19, 2017
Merged

Implemented separated matched data for different locaitons #453

merged 2 commits into from Oct 19, 2017

Conversation

villamide
Copy link

@villamide villamide commented Oct 13, 2017 •
edited by gustavohenke

Implemented locations in matchedData to be able to get matched data from specified fields (like body, params...)

Closes #447

@coveralls
Copy link

coveralls commented Oct 13, 2017 •
edited

Coverage Status

Coverage decreased (-0.3%) to 99.742% when pulling 67927e4 on villamide:matched-data-separated into 5f84536 on ctavan:master.

@coveralls
Copy link

coveralls commented Oct 13, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 15568e9 on villamide:matched-data-separated into 5f84536 on ctavan:master.

@gustavohenke gustavohenke self-requested a review October 13, 2017 16:44
@coveralls
Copy link

coveralls commented Oct 18, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 8d98194 on villamide:matched-data-separated into 94e8c1f on ctavan:master.

@coveralls
Copy link

coveralls commented Oct 19, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 84b2afe on villamide:matched-data-separated into 94e8c1f on ctavan:master.

@gustavohenke gustavohenke merged commit b7dbb5a into express-validator:master Oct 19, 2017
@coveralls
Copy link

coveralls commented Oct 19, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling bb5f928 on villamide:matched-data-separated into 94e8c1f on ctavan:master.

@gustavohenke
Copy link
Member

Very nice first contribution on GitHub, @villamide! 😄

As you will find out, I changed a few things. But your implementation is awesome, thanks!

@gustavohenke
Copy link
Member

Published in v4.3.0 🚢

@lock
Copy link

lock bot commented May 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can matchedData return just the body validated params?
3 participants
@villamide @coveralls @gustavohenke