New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix profiler path validation #656
Fix profiler path validation #656
Conversation
…tTarget() to constructor
Target executables specified with relative paths are now supported, whether the PATH environment variable is acquired from the pkexec runtime environment (On RHEL8.6: If the PATH env var provided by the user on the Profiler Page, the below syntax is supported and expanded in the following order::
This new expanded |
If you aren't running as Also, if not running as |
Is this ready? |
No. Worked it yesterday; As requested in review, added dict key checking for robustness, and adding requested unit-tests. Have not pushed latest work. Hopefully today. |
…lace all dict[] reads with gets
Opened #670 related to the Profiler's default |
@tparchambault conflicts in the main .pot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected 👍
Resoled the conflict, was just the file info date/time conflicting. |
Support for validating relative executable paths by using the existing PATH from the users environment. This also supports evaluating a custom PATH provided through the profiler GUI.
This fixes the issue from #655 where users are forced to use absolute paths to avoid a validation error reporting that the file cannot be found.
Closes #655