Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File change doesn't work anymore from Nova v4.22.0 #96

Closed
eullercdr opened this issue Feb 13, 2023 · 12 comments
Closed

File change doesn't work anymore from Nova v4.22.0 #96

eullercdr opened this issue Feb 13, 2023 · 12 comments
Labels
bug Something isn't working

Comments

@eullercdr
Copy link

@ctessier Can you tell me why the package is not working anymore? I'm using the latest version of Nova.

@ctessier
Copy link
Owner

Hi @eullercdr
What version of the package are you running?

@eullercdr
Copy link
Author

@ctessier I am using the version ctessier/nova-advanced-image-field": "^2.0

@ctessier
Copy link
Owner

OK
You should be a little more specific though...

What doesn't work anymore? Which version of Nova? What error do you get? What does you resource class look like? What is your version of PHP?

@mziraki
Copy link
Contributor

mziraki commented Feb 14, 2023

@ctessier it's v4.22.0, it's working on v4.21.0

@ctessier
Copy link
Owner

ctessier commented Feb 14, 2023

I can't reproduce any issue with Nova v4.22.0

Guys! Give me a little more to work from, here!
What doesn't work anymore? What error do you get? What does you resource class look like? What is your version of PHP?

@puzzledmonkey
Copy link
Contributor

it doesn't work with Nova 4.22.0 because they changed the behaviour of DropZone
image
in short, you need to update to use @file-changed="handleFileChange" instead of just @change="handleFileChange"
presumably you can use both of them to ensure backwards compatibility too?

@puzzledmonkey
Copy link
Contributor

#97

I've tested and with the @change line kept as well as the new @file-changed line, it works in Nova <4.22.0 too.

:)

@ctessier
Copy link
Owner

Thank you @puzzledmonkey

I'll have a look at your PR asap!
I didn't have any issue while choosing a file, is only the dropzone affected?

@puzzledmonkey
Copy link
Contributor

it doesn't work for me when choosing a file or when dropping a file on the dropzone.

you might have another plugin installed that's overwriting the dropzone code i guess? but here i had no luck with any uploading until i added that @file-changed line.

@ctessier
Copy link
Owner

Thank you very much @puzzledmonkey !
I was able to reproduce. I will publish a new version with your fix!

Good work, thank you!

@ctessier ctessier changed the title Doesn't work anymore File change doesn't work anymore from Nova v4.22.0 Feb 15, 2023
@ctessier ctessier added the bug Something isn't working label Feb 15, 2023
@ctessier
Copy link
Owner

This issue was fixed in v2.0.2. Thank you @puzzledmonkey for your contribution 😉

@Woeler
Copy link
Contributor

Woeler commented Feb 16, 2023

Cheers for fixing this. Ran into it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants