Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade, the translations are no longer shown #8

Closed
sten opened this issue Jul 17, 2018 · 10 comments
Closed

After upgrade, the translations are no longer shown #8

sten opened this issue Jul 17, 2018 · 10 comments
Labels

Comments

@sten
Copy link

sten commented Jul 17, 2018

Hello,

First and foremost, thank you for this great library!

Everything worked well, until I updated to the latest version (1.4). I can no longer see the translations. It seems that Vue retrieves the translations correctly, because the counter is updated and correct, but nothing is filled in in the table. The following screenshot illustrates the situation:
screen shot 2018-07-17 at 11 16 10

I have updated the js libs using yarn, re-ran the publish step and ran npm run watch
I do not see any errors in the console, and I have tried to debug the app a bit but I am not experienced in Vue.js so I am stuck. Do you have any idea what might be the issue?

Thanks a lot!

@ctf0
Copy link
Owner

ctf0 commented Jul 18, 2018

i've made a demo repo https://github.com/ctf0/demos/tree/lingo, can u plz check with it

if you can make a repo with ur setup it would be even easier to debug.

@ctf0 ctf0 added the question label Jul 18, 2018
@ctf0
Copy link
Owner

ctf0 commented Jul 18, 2018

you need to update the js files, because the code was refactored

@ctf0 ctf0 closed this as completed Jul 18, 2018
@michielabe
Copy link

What do you mean by updating the js files? I've run npm run watch but that doesn't fix it.

@ctf0
Copy link
Owner

ctf0 commented Jul 25, 2018

@michielabe

because the code was refactored

@michielabe
Copy link

So what exactly do I need to do to update the js files?

@ctf0
Copy link
Owner

ctf0 commented Jul 26, 2018

force republish the assets

$this->publishes([
__DIR__ . '/resources/assets' => resource_path('assets/vendor/Lingo'),
], 'assets');

php artisan vendor:publish --provider="ctf0\Lingo\LingoServiceProvider" --tag="assets"

@sten
Copy link
Author

sten commented Jul 30, 2018

@ctf0 I manually removed all files and republished the assets and ran nvm run watch. However it still did not work. It appears the published view of Lingo in resources/views/vendor/Lingo/lingo.blade.php was still the old version, which did not have the right routes format and broke the whole thing. So after replacing this everything works! Thanks for your help!!!

@ctf0
Copy link
Owner

ctf0 commented Jul 30, 2018

@sten glad it worked but in v1.4.0 the view didnt change much
21de4b0#diff-e8edc00e0c4e38b8abe500ee7e83df7c

unless u were using an old file that didnt have the download routes, still i will update the rdme

@sten
Copy link
Author

sten commented Jul 30, 2018

@ctf0 Exactly, I was missing the routes array attribute.

@ctf0
Copy link
Owner

ctf0 commented Jul 30, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants