Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headers filtering is too strict #219

Closed
skyboyer opened this issue Oct 11, 2019 · 1 comment
Closed

headers filtering is too strict #219

skyboyer opened this issue Oct 11, 2019 · 1 comment

Comments

@skyboyer
Copy link

Headers validation has been implemented in #70 to make such a thing:

mock.onPatch('/someHandler', undefined, { "X-CSRF": "mockedToken" }).reply(200)

But by now we have to specify all the headers not just few we want to focus on.
It's because isRequestHeadersMatching finally uses deepEqual to find appropriate handler.

Is it intentional for any reason? If no, I'd like to send a patch.

PS Also see no docs on headers filtering at main page. Is it also intentional for any reason(like API has not stabilized yet and still may change or kind of that)? If no, I'd like to help on that too.

@skyboyer skyboyer changed the title headers filtering is too headers filtering is too strict Oct 11, 2019
@skyboyer
Copy link
Author

skyboyer commented Oct 11, 2019

seems it duplicates #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants