Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown linter execution in GitHub actions #200

Merged
merged 3 commits into from Aug 29, 2022
Merged

Fix markdown linter execution in GitHub actions #200

merged 3 commits into from Aug 29, 2022

Conversation

fadeevab
Copy link
Contributor

@fadeevab fadeevab commented Aug 27, 2022

Problem: "Cannot find module 'node:path'"
Cause: Current markdownlint version is not compatible with node10
Measure: use node16 explicitly

Also, fixed linter errors: remove not existing resources.

BEFORE

image

AFTER

image

Problem: "Cannot find module 'node:path'"
Cause: Current markdownlint version is not compatible with node10
Measure: use node16 explicitly
@fadeevab
Copy link
Contributor Author

@ctjhoa It's going to fix your GitHub actions. Thanks

@fadeevab
Copy link
Contributor Author

All right, I see that there is still a problem with pr.yml, I will fix it

@fadeevab
Copy link
Contributor Author

@ctjhoa I fixed the PR linter as well, please, re-run CI
image

@fadeevab
Copy link
Contributor Author

Now you can see it works :)

@ctjhoa
Copy link
Owner

ctjhoa commented Aug 29, 2022

Thank you! I really appreciate that.

@ctjhoa ctjhoa merged commit 928063f into ctjhoa:master Aug 29, 2022
@fadeevab fadeevab deleted the fix/actions-markdown-linter branch August 30, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants