Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite test suite to accommodate compatibility across python 3.8/3.9 boundary #2

Open
ctk3b opened this issue Sep 17, 2021 · 2 comments

Comments

@ctk3b
Copy link
Owner

ctk3b commented Sep 17, 2021

See python 3.9 failures here: https://github.com/ctk3b/borderline/runs/3627419435

@ctk3b
Copy link
Owner Author

ctk3b commented Sep 17, 2021

Documented problem here:

borderline/borderline.py

Lines 36 to 43 in 601c5b3

Notes
-----
`ast.dump` does not produce identical results across python versions. If you
are relying on grandfather files, you may need to regenerate them when updating
python versions.
Specifically, from python 3.8->3.9, `Import` and `ImportFrom` nodes no longer
`ast.dump` an `asname` attribute.

@ctk3b
Copy link
Owner Author

ctk3b commented Sep 17, 2021

3.9 works just fine but we'd have to rewrite the unit tests to accommodate differences across python versions

@ctk3b ctk3b changed the title Compatibility across python versions Rewrite test suite to accommodate compatibility across python 3.8/3.9 boundary Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant