-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable buttons and checkboxes in the click handler #1173
Comments
I removed the |
BTW, there's a chance that doing this naively will actually have an embarrassing downside, so it's best to only work on this when I can start running tests on devctm.com again. IOW, I absolutely shouldn't do this during the WSOPS Series on craftpoker.com. |
Not doing this makes it impossible for people to know that their click was seen if they're lagged. LLew, for example, said in chat:
and looking at the logs I see:
which basically means she was clicking on the advanced action check box, not getting any feedback and then clicking again. That is extremely unfair to anyone and would put someone off the interface, whereas if we were to disable the checkbox on the first click, we could at least document what is going on until we do a little further and actually put lag detection into the client (#160). So, I've added the |
BTW, disabling a button makes sense, but disabling check-boxes is probably not what we want to do, because someone can change their mind during the lag. It makes more sense to tentatively update the check-box with the value desired, but to change it to gray and add a tooltip that succinctly explains that the message has been sent, but not yet acknowledged. Unfortunately, that requires more coding than merely disabling. |
In light of the above comment, this issue is really not easy and since it's not easy, and since we need a more encompassing lag reporting system, I'm stripping it of both |
Find the various places where mb2 accepts clicks and make sure that in the click handler itself, the button is disabled.
This is a fix on the client side for the problem I just fixed on the server side (#1166). In theory, since it's fixed on the server side, the particular behavior we saw won't happen, but it should be fixed in both places, especially since there still could be weirdness in the UI.
The text was updated successfully, but these errors were encountered: