Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable buttons and checkboxes in the click handler #1173

Open
ctm opened this issue Jun 3, 2023 · 5 comments
Open

disable buttons and checkboxes in the click handler #1173

ctm opened this issue Jun 3, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ctm
Copy link
Owner

ctm commented Jun 3, 2023

Find the various places where mb2 accepts clicks and make sure that in the click handler itself, the button is disabled.

This is a fix on the client side for the problem I just fixed on the server side (#1166). In theory, since it's fixed on the server side, the particular behavior we saw won't happen, but it should be fixed in both places, especially since there still could be weirdness in the UI.

@ctm ctm added bug Something isn't working high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Jun 3, 2023
@ctm ctm self-assigned this Jun 3, 2023
@ctm ctm removed the high priority Should be done fairly soon label Jun 5, 2023
@ctm
Copy link
Owner Author

ctm commented Jun 5, 2023

I removed the high priority label, because I don't see this causing trouble, and I have a lot more important things to do right now.

@ctm
Copy link
Owner Author

ctm commented Jun 5, 2023

BTW, there's a chance that doing this naively will actually have an embarrassing downside, so it's best to only work on this when I can start running tests on devctm.com again. IOW, I absolutely shouldn't do this during the WSOPS Series on craftpoker.com.

@ctm ctm added the high priority Should be done fairly soon label Jun 15, 2023
@ctm
Copy link
Owner Author

ctm commented Jun 15, 2023

Not doing this makes it impossible for people to know that their click was seen if they're lagged. LLew, for example, said in chat:

whats going on? i had to check like 5 times!

and looking at the logs I see:

mb2=> select id, hand_id, received_at at time zone 'america/denver', message from private_table_messages where player_id = 23 and table_id = 5179 order by received_at;
[...]
 11431912 |  350781 | 2023-06-14 18:31:19.287043 | "AdvancedActionCleared"
 11431913 |  350781 | 2023-06-14 18:31:33.892105 | "AdvancedActionCleared"
 11431915 |  350781 | 2023-06-14 18:31:33.897036 | {"ActionSet": "Check"}
 11431916 |  350781 | 2023-06-14 18:31:33.897041 | {"ActionSet": "Check"}
 11431917 |  350781 | 2023-06-14 18:31:33.897042 | {"ActionSet": "Check"}
 11431918 |  350781 | 2023-06-14 18:31:33.897043 | {"ActionSet": "Check"}
 11431935 |  350781 | 2023-06-14 18:31:57.382103 | {"CantCheck": 1500}

which basically means she was clicking on the advanced action check box, not getting any feedback and then clicking again.

That is extremely unfair to anyone and would put someone off the interface, whereas if we were to disable the checkbox on the first click, we could at least document what is going on until we do a little further and actually put lag detection into the client (#160).

So, I've added the high priority label back in.

@ctm
Copy link
Owner Author

ctm commented Jun 15, 2023

BTW, disabling a button makes sense, but disabling check-boxes is probably not what we want to do, because someone can change their mind during the lag. It makes more sense to tentatively update the check-box with the value desired, but to change it to gray and add a tooltip that succinctly explains that the message has been sent, but not yet acknowledged. Unfortunately, that requires more coding than merely disabling.

@ctm
Copy link
Owner Author

ctm commented Jan 12, 2024

In light of the above comment, this issue is really not easy and since it's not easy, and since we need a more encompassing lag reporting system, I'm stripping it of both easy and high priority.

@ctm ctm removed high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant