Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pop-up enabling in Chrome and Safari #1299

Open
ctm opened this issue Jan 26, 2024 · 5 comments
Open

Document pop-up enabling in Chrome and Safari #1299

ctm opened this issue Jan 26, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon

Comments

@ctm
Copy link
Owner

ctm commented Jan 26, 2024

Add documentation to the Players' Manual how to disable pop-up blockers on Chrome and Safari.

At least one case of lag between when mb2 tells the Lobby there's a new game and when the player gets a table window is due to the pop-up blocker on Chrome. Since Chrome and Safari are very popular (and Firefox has issues), it makes sense to add a quick explanation on how to do a site-specific override.

@ctm ctm added documentation Improvements or additions to documentation high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels Jan 26, 2024
@ctm ctm self-assigned this Jan 26, 2024
@fladjoe74
Copy link

Please assign this issue to me and I will add this asap!

@ctm
Copy link
Owner Author

ctm commented Jan 30, 2024

Thanks!

@fladjoe74
Copy link

Hey @ctm I don't have access to the manual, so can you please copy and paste from this doc?

@ctm
Copy link
Owner Author

ctm commented Jan 31, 2024

Thanks!

I see yours is a new GitHub account, and so I assume you're relatively new to GitHub.

This repository is the manual, so if you clone it, you can make a pull-request. This manual is written in MarkDown and is formatted with mdbook.

If the above is enough info for you to get your mods into the right format, tested locally by you and a pull-request created, great. If not, I'll go ahead and do it, but it probably won't be today.

@ctm
Copy link
Owner Author

ctm commented Feb 13, 2024

I can get a list of who this is happening to and how many times via select player_id, nick, count(player_id) from lobby_requests join players on player_id = players.id where variant = 27 group by player_id, nick order by count(player_id) desc;.

The above shows 8 players who have been bitten by pop-up failure five or more times since I added instrumentation, two players bitten three times, four twice and eight just once.

I'll guess most of the people who have only been bitten a small number of times were only playing a small number of time and were only there for WYWAE, but there are some notable exceptions of regular players who only had trouble once or twice. I may send email and ask about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon
Projects
None yet
Development

No branches or pull requests

2 participants