Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-ons don't play well with synchronized breaks #1346

Open
ctm opened this issue Mar 10, 2024 · 1 comment
Open

Add-ons don't play well with synchronized breaks #1346

ctm opened this issue Mar 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ctm
Copy link
Owner

ctm commented Mar 10, 2024

FIgure out how to make add-ons play with synchronized breaks.

I added add-ons before adding synchronized breaks. When I added synchronized breaks I didn't think about add-ons and the fact that they're level based and normally are set up to occur on breaks.

I'm labeling this high priority but only so that I can think about it and figure out how to proceed. Unless it's super easy to fix, I'll probably strip high priority from the implementation.

@ctm ctm added bug Something isn't working high priority Should be done fairly soon labels Mar 10, 2024
@ctm ctm self-assigned this Mar 10, 2024
@ctm
Copy link
Owner Author

ctm commented Mar 26, 2024

I never really did think about this much, but my inclination is to make it so that a one minute break is added for people to decide whether or not to add on. However, what if that break is super close to the synchornized break? Should the synchronized break be used instead?

Since there are no structures with add-ons in WSOPS, this is definitely not a high priority. However, it's still a bug, so once I'm done with high priority items, it probably makes sense, at minimum, to disallow synchronized breaks when add-ons are present and probably to also not offer structures that can't have synchronized breaks in the default list of structures people can pick.

@ctm ctm removed the high priority Should be done fairly soon label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant