Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove str conversions in all rules #125

Open
boulund opened this issue Jan 15, 2020 · 2 comments
Open

Remove str conversions in all rules #125

boulund opened this issue Jan 15, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@boulund
Copy link
Member

boulund commented Jan 15, 2020

Snakemake should be Pathlib compatible across the board now, so it should be possible to remove all the superfluous str conversions in all rules.
@boulund boulund added the enhancement New feature or request label Jan 15, 2020
@boulund boulund added this to the V4 milestone Jan 15, 2020
@boulund boulund added the good first issue Good for newcomers label Jan 15, 2020
@boulund
Copy link
Member Author

boulund commented Jan 16, 2020

This has the drawback of making the workflow depend on a very recent Snakemake version. It has the benefit of making the code for the rules a bit more clean-looking.

@boulund boulund modified the milestones: V4, V4.1 Feb 17, 2020
@boulund boulund removed this from the V4.1 milestone Apr 17, 2023
@boulund
Copy link
Member Author

boulund commented Apr 17, 2023

I started fixing this as I go along with updates in versions of StaG after the recent v0.6.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boulund