Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParentID as an option to Conf Page Create #211

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

squatched
Copy link
Contributor

@squatched squatched commented Jun 5, 2023

Fixes #210 by adding ParentID to create page request.

See
https://developer.atlassian.com/cloud/confluence/rest/v2/api-group-page/#api-pages-post
where parentId is an option for the request.

@ctreminiom ctreminiom added enhancement New feature or request Confluence labels Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (810da40) to head (588a6fc).

❗ Current head 588a6fc differs from pull request most recent head 7547470. Consider uploading reports for the commit 7547470 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   89.19%   89.25%   +0.05%     
==========================================
  Files         154      148       -6     
  Lines       12044    11626     -418     
==========================================
- Hits        10743    10377     -366     
+ Misses        659      632      -27     
+ Partials      642      617      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squatched
Copy link
Contributor Author

Documentation PR: ctreminiom/go-atlassian-docs#2

@ctreminiom ctreminiom added this to the Confluence Cloud V2 Module milestone Jun 18, 2023
@ctreminiom
Copy link
Owner

closing pr due inactivity

@ctreminiom ctreminiom closed this Aug 14, 2023
@squatched
Copy link
Contributor Author

I'm sorry but what activity was needed? I don't see any feedback here and I've been using a custom build of go-atlassian using this PR for weeks now without issue. Is there something that needs to change?

@ctreminiom ctreminiom reopened this Aug 17, 2023
@squatched
Copy link
Contributor Author

What needs to be done to get this merged? Anything I can help with?

@squatched
Copy link
Contributor Author

I'm not sure why this received the "breaking-change" label (I VAGUELY recall some comment somewhere with that term but I don't remember where it is and I just re-examined these changes and I don't see how adding a field to the PageCreatePayloadScheme struct that is labeled omitempty could be considered a breaking change as any existing declarations of the struct with it omitted will simply initialize to empty string and then that won't get passed to the API so default behavior is achieved). Could this get merged any time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Unable To Specify ParentID For Conf v2 POST Create Page
2 participants