Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:import and export configs. #1767

Merged
merged 8 commits into from Dec 16, 2018
Merged

feat:import and export configs. #1767

merged 8 commits into from Dec 16, 2018

Conversation

JaredTan95
Copy link
Member

add a API for import a config file to namespace and export namespace's configs to file.
But no UI changes.:-P

@JaredTan95
Copy link
Member Author

related issues:#1760 #1681

@codecov-io
Copy link

Codecov Report

Merging #1767 into master will decrease coverage by 0.19%.
The diff coverage is 1.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #1767     +/-   ##
===========================================
- Coverage     48.53%   48.33%   -0.2%     
- Complexity     1910     1913      +3     
===========================================
  Files           392      394      +2     
  Lines         11617    11670     +53     
  Branches       1219     1223      +4     
===========================================
+ Hits           5638     5641      +3     
- Misses         5531     5582     +51     
+ Partials        448      447      -1
Impacted Files Coverage Δ Complexity Δ
...ramework/apollo/portal/util/ConfigToFileUtils.java 0% <0%> (ø) 0 <0> (?)
...llo/portal/controller/ConfigsExportController.java 2.32% <2.32%> (ø) 1 <1> (?)
.../apollo/internals/RemoteConfigLongPollService.java 77.91% <0%> (+0.61%) 28% <0%> (+1%) ⬆️
...amework/apollo/openapi/util/ConsumerAuditUtil.java 83.33% <0%> (+2.77%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc4983...643b9b7. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #1767 into master will decrease coverage by 0.23%.
The diff coverage is 1.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1767      +/-   ##
============================================
- Coverage     48.55%   48.32%   -0.24%     
  Complexity     1913     1913              
============================================
  Files           392      394       +2     
  Lines         11620    11676      +56     
  Branches       1219     1225       +6     
============================================
  Hits           5642     5642              
- Misses         5532     5587      +55     
- Partials        446      447       +1
Impacted Files Coverage Δ Complexity Δ
...ramework/apollo/portal/util/ConfigToFileUtils.java 0% <0%> (ø) 0 <0> (?)
...llo/portal/controller/ConfigsExportController.java 2.17% <2.17%> (ø) 1 <1> (?)
...ervice/service/ReleaseMessageServiceWithCache.java 85.71% <0%> (-1.2%) 24% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4aa9f7...eaef910. Read the comment docs.

@coveralls
Copy link

coveralls commented Dec 12, 2018

Coverage Status

Coverage decreased (-0.2%) to 52.15% when pulling eaef910 on JaredTan95:config-export into e4aa9f7 on ctripcorp:master.

@nobodyiam
Copy link
Member

Thanks! Will take a detailed look soon.

@JaredTan95
Copy link
Member Author

JaredTan95 commented Dec 15, 2018

@nobodyiam It seems ci has failed, but it was ok in my local env. I couldn't trigger CI to rerun. Can you rerun it and to check it together?

@nobodyiam
Copy link
Member

nobodyiam commented Dec 15, 2018

@JaredTan95

I just triggered it manually. Actually you could trigger it by pushing the remote branch again, with a rebase or squash merge.

And in this case, since there are 6 commits in one feature branch, I would also suggest you using rebase or squash merge to combine those 6 commits into 1. Would you please help to do so?

fix check.

throw exception.

refactoring

add known user

add known user

close InputStream.
fix check.

throw exception.

refactoring

add known user

add known user

close InputStream.
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 152b032 into apolloconfig:master Dec 16, 2018
@JaredTan95 JaredTan95 deleted the config-export branch December 16, 2018 03:08
@Anilople Anilople mentioned this pull request May 20, 2020
4 tasks
@Anilople Anilople added area/operations Information technology operations area/portal apollo-portal feature Categorizes issue as related to a new feature. labels Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Information technology operations area/portal apollo-portal feature Categorizes issue as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants