Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAPI to rollback config. (#2351) #2581

Merged
merged 3 commits into from Oct 1, 2019
Merged

Add OpenAPI to rollback config. (#2351) #2581

merged 3 commits into from Oct 1, 2019

Conversation

Accelerator96
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 9, 2019

Codecov Report

Merging #2581 into master will decrease coverage by 0.04%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2581      +/-   ##
============================================
- Coverage     50.09%   50.04%   -0.05%     
  Complexity     2047     2047              
============================================
  Files           412      412              
  Lines         12586    12594       +8     
  Branches       1289     1291       +2     
============================================
- Hits           6305     6303       -2     
- Misses         5834     5843       +9     
- Partials        447      448       +1
Impacted Files Coverage Δ Complexity Δ
...pollo/openapi/v1/controller/ReleaseController.java 10.52% <22.22%> (+0.32%) 1 <1> (ø) ⬇️
...mework/apollo/portal/component/PortalSettings.java 65.07% <0%> (-4.77%) 5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe28113...272b8e4. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 9, 2019

Coverage Status

Coverage decreased (-0.04%) to 53.605% when pulling 272b8e4 on Accelerater:master into fe28113 on ctripcorp:master.

@JaredTan95 JaredTan95 added this to the 1.5.0 milestone Sep 10, 2019
@JaredTan95
Copy link
Member

#2351

Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, you also need to publish an event to like: com.ctrip.framework.apollo.portal.controller.ReleaseController#rollback---> ConfigPublishEvent?

@Accelerator96
Copy link
Contributor Author

I think, you also need to publish an event to like: com.ctrip.framework.apollo.portal.controller.ReleaseController#rollback---> ConfigPublishEvent?

like:
com.ctrip.framework.apollo.openapi.v1.controller#createRelease
i think openapi don't need add ConfigPublishEvent。

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants