Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimap并未严格保持@EnableApolloConfig注解中namespace定义的顺序。 #962

Merged
merged 2 commits into from Feb 9, 2018

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Feb 9, 2018

e.g:
@EnableApolloConfig({"application","FX.apollo"})情况下,最终environment.getPropertySources取出的顺序为"application","FX.apollo",然而在@EnableApolloConfig({"FX.apollo","application"})情况下,取出的顺序为"application","FX.apollo"。

@codecov-io
Copy link

codecov-io commented Feb 9, 2018

Codecov Report

Merging #962 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #962      +/-   ##
============================================
- Coverage     46.99%   46.91%   -0.08%     
+ Complexity     1557     1554       -3     
============================================
  Files           354      354              
  Lines          9755     9755              
  Branches        968      968              
============================================
- Hits           4584     4577       -7     
- Misses         4829     4835       +6     
- Partials        342      343       +1
Impacted Files Coverage Δ Complexity Δ
...apollo/spring/config/PropertySourcesProcessor.java 100% <100%> (ø) 12 <1> (ø) ⬇️
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (-10.42%) 6% <0%> (-2%)
.../apollo/internals/RemoteConfigLongPollService.java 76.68% <0%> (-1.23%) 27% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3573f3e...a2c9158. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 50.436% when pulling a2c9158 on JaredTan95:master into 3573f3e on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nobodyiam nobodyiam merged commit ebbeef6 into apolloconfig:master Feb 9, 2018
nobodyiam added a commit to nobodyiam/apollo that referenced this pull request Feb 9, 2018
nobodyiam added a commit that referenced this pull request Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants