Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Resize Observer? #215

Open
keul opened this issue Jun 22, 2021 · 2 comments
Open

Use Resize Observer? #215

keul opened this issue Jun 22, 2021 · 2 comments

Comments

@keul
Copy link

keul commented Jun 22, 2021

This pretty good library carries a not-so-small bundle size change: https://bundlephobia.com/package/react-sizeme@3.0.1

It seems this largely depends on the element-resize-detector dependency.

I'm wondering is you ever evaluated a switch to the Resize Observer API for this.

I know this would be a task to defer to element-resize-detector probably, but it seems that the author has a different opinion.

Any thoughts?

@sean-tmg
Copy link

sean-tmg commented Aug 23, 2021

Hi @keul;

It's a fair question. I am open to switching to the Resize Observer API, but for now I intend for this package to exist in order support a wider set of browsers. Once the ecosystem has evolved to a point that we no longer need to support older browsers I may update this package or declare it archived. 🙏

@keul
Copy link
Author

keul commented Aug 23, 2021

@sean-tmg I understand the scope to support wider range of browsers! Just a note: there are some Resize Observer polyfills out there, so in case devs could add them if they really need to support older browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants