Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Question about index.js exports (for components) #161

Closed
evgenyboxer opened this issue Nov 4, 2016 · 5 comments
Closed

Question about index.js exports (for components) #161

evgenyboxer opened this issue Nov 4, 2016 · 5 comments

Comments

@evgenyboxer
Copy link
Contributor

I've noticed that the index.js usually looks like this:

import ComponentName from './ComponentName';
export default ComponentName;

We can use a shorter one liner:

export { default } from './ComponentName';

I can send a PR for this, if you like this too :)

@ctrlplusb
Copy link
Owner

Thanks @evgenyboxer! Any and all improvements are appreciated. The simpler the better. :)

@evgenyboxer
Copy link
Contributor Author

I created PR for this:
#172 (master)
#173 (redux)
#174 (apollo)

Enjoy your holiday! I love this starter kit! 👍

We should probably make a website for it!

@ctrlplusb
Copy link
Owner

Thanks @evgenyboxer !!

Something seemed strange with the Apollo PR. I think github had a hiccup. I will check in when I am back.

Thanks for your help and interest. Much appreciated!!

@ctrlplusb
Copy link
Owner

P.S. I wonder what we could.use to build the website with? 🤔

😜

@ctrlplusb
Copy link
Owner

Looks like this made it through.

Thanks everyone for helping make it happen in my absence.

x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants