Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Modular and/or React Scripts approach #181

Closed
strues opened this issue Nov 18, 2016 · 8 comments
Closed

Modular and/or React Scripts approach #181

strues opened this issue Nov 18, 2016 · 8 comments

Comments

@strues
Copy link
Collaborator

strues commented Nov 18, 2016

This is two discussion topics rolled into this issue.

  1. Thoughts on refactoring the meat of the Webpack config into their own separate files? My reasoning is there's a lot going on in the configuration and it can be overwhelming. Splitting into multiple small files would make it easier to digest, as well as present a plug-in-play environment for the end user.

  2. Take the concept behind react-scripts and make the build toolkit its own installable package. Hiding the complexities from the end user.

@enten
Copy link
Collaborator

enten commented Nov 18, 2016

I wrote wcf to assist webpack configuration definition (inspired by the current webpack/configFactory.js).

That is a re-writing of the webpack/configFatory.js with wcf (I had mentioned it here)

I hope it can help for Webpack config refactoring.

@kompot
Copy link

kompot commented Nov 20, 2016

One more project on webpack modularity/composability that might be of some value for this issue
https://github.com/andywer/webpack-blocks

@ctrlplusb
Copy link
Owner

Some great points @strues - I shall reply more appropriately soon. :)

@ctrlplusb
Copy link
Owner

Some cross over with #192

@ctrlplusb
Copy link
Owner

ctrlplusb commented Nov 28, 2016

Another consideration: terse-webpack

Also liking webpack-merge which could be abstracted around.

@enten
Copy link
Collaborator

enten commented Nov 28, 2016

terse-webpack is awesome! I wrote wcf with the same purposes.

It could be better if terse-weback allow more flexibility with when() (which filter on NODE_ENV only), allow multiple targets building with one definition, allow custom hooks and accept a context in getConfig() which will be passed through configurations hooks/reducers.

@ctrlplusb
Copy link
Owner

Yeah, it definitely has it's limitations. I'm excited to go through your wcf. :)

@ctrlplusb
Copy link
Owner

Closing in favour of #201

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants