Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/expand FRSL configuration #11

Closed
tbembersimeao opened this issue Apr 4, 2018 · 6 comments
Closed

Improve/expand FRSL configuration #11

tbembersimeao opened this issue Apr 4, 2018 · 6 comments
Assignees

Comments

@tbembersimeao
Copy link
Contributor

tbembersimeao commented Apr 4, 2018

Currently, FRSL configuration form is limited:

  • Only one control field
  • Only one operator (OR) for multiple conditions over the same instrument

The ideal solution for this is hijacking REDCap's branching logic form, which would be powerful and user friendly. But since this approach would take a considerable amount of time to implement, I would like to brainstorm middle ground solutions for this.

We could start, for instance, by hijacking the "Advanced Branching Logic Syntax" only - which is a simple text area field - alongside with a popup helper. Later on we could build on top of it.

@pbchase @tlstoffs any thoughts?

@tlstoffs
Copy link

tlstoffs commented Apr 5, 2018

  • Only one operator (OR) for multiple conditions over the same instrument – I’m not sure what you mean by this ☹ It looks like you can assign a form to show up for multiple conditions (Control field). I just did this in the FRSL project (PID 4051), where I was able to assign the ‘Butterfly Data’ form to both Butterflies and Parrots. However, I’m not sure that’s what you are referring to...

  • Only one control field – having more than one would be nice/useful. I can definitely see users needing more than one control field.

@tbembersimeao
Copy link
Contributor Author

tbembersimeao commented Apr 5, 2018

@tlstoffs yes, the explanation was confusing. Rephrasing:

For the configuration example below, prescription_form shows up if control value is 1 or 2. If we decide to allow multiple control fields, we will need to support statements like <condition 1> and <condition 2> on the interface.

screen shot 2018-04-05 at 1 28 08 pm

It's the same principle as REDCap's Drag-N-Drop Logic Builder:

screen_shot_2018-04-05_at_1_47_00_pm

@pbchase
Copy link
Contributor

pbchase commented May 31, 2018

The "one control field" limitation has been fixed by PR #19.

@tbembersimeao
Copy link
Contributor Author

tbembersimeao commented May 31, 2018

Indeed, the new version introduces a few features:

  • Multiple control fields
  • Comparison operators (=, >, <, <>, etc)
  • Ability of limit visibility rules to specific events
  • UI improvements (like aggregating multiple forms under the same condition)

The only limitation left is the case in where multiple conditions are required to display a given form at the same time (not just one of them). Not sure how to solve this yet, maybe in a next major release.

@tbembersimeao
Copy link
Contributor Author

tbembersimeao commented May 31, 2018

Another interesting feature that @pbchase and I discussed a few days ago is having a grade of checkboxes (instruments x events) in which we can pick individual forms to be displayed.

Something like:

              Event 1  Event 2  Event 3
Instrument 1  [ ]      [x]      [ ]
Instrument 2  [x]      [ ]      [ ]
Instrument 3  [ ]      [ ]      [x]

That would bring an extra flexibility, plus it's way more user friendly.

@pbchase
Copy link
Contributor

pbchase commented Aug 16, 2018

All of the desires discussed in this issue can be addressed in the current release of FRSL, version 3.3.3. To get a multi-valued control field used the Advanced Control field feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants