Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deploy 'non-versioned files' during upgrades #44

Open
pbchase opened this issue May 9, 2018 · 1 comment
Open

How to deploy 'non-versioned files' during upgrades #44

pbchase opened this issue May 9, 2018 · 1 comment

Comments

@pbchase
Copy link
Contributor

pbchase commented May 9, 2018

The redcap_deployment does not have a good method for deploying REDCap's "non-versioned files" during an upgrade. One will get messages like this:

non-versioned_files_warning

While there are reasons this warning could be a false-positive, there are plenty more reasons why it is a legitimate alert that should be addressed. On this particular host, these files were out of date:

./Instructions.txt
./redcap/ehr.php
./redcap/index.php
./redcap/redcap_connect.php
./redcap/cron.php
./redcap/surveys/index.php
./redcap/api/index.php
./redcap/api/help/index.php

Instructions.txt is not a problem, but every other file is.

One possible solution is to use the redcapX.Y.Z.zip files instead of the redcapX.Y.Z_upgrade.zip. With the recent change that excludes the database.php file found inside redcapX.Y.Z_upgrade.zip during upgrade (commit # 9db03a2) this might be a viable solution.

@pbchase
Copy link
Contributor Author

pbchase commented May 10, 2018

In a private conversation, Rob Taylor said:

...Database.php and hook_functions.php are the only files in the root directory that should not be overwritten that I am aware of. You personally may not have modified hook_functions.php from its original state, but others might...

I think we should default to not replacing hook_functions.php. If we do replace it, that should be an option controlled by a parameter in the INI file. This would conform with redcap_deployment's direction of waning support for hook frameworks as we grow module support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant