-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console log incorrectly reports all trades as PONG #1047
Comments
This comment has been minimized.
This comment has been minimized.
Actually, there are PINGs, but only when the bot starts... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
im sorry maybe is cos is to late here but what means in any case having a value of |
🐨 i cannot reproduce this, but let me know if you still want to reopen the issue :S |
Yes, it is still an issue. Have a look here: ... and in the console: Here is on the SELL side: As the QE is treating it as PONG, it also does not respect trades/sec protection. Also, The bot should only ping at BidSide, but fails to stop pinging at SellSide!!! When I restart Please, reopen this and let me know if you need any other information. |
Any update on this? It's related to the issue described in this discussion thread: #1069 If the bot does not reliably ping/pong, strategies involving HFT are not viable (on boomerang?) because the bot will not reliably close positions (AKA take profit) when opportunities present themselves. There have been cases where K has pong'd itself into TBP held state with no actual pings available. Once again, to illustrate my point, this should not happen with a pongWidth% of 0.001: |
@MiningInMySleep As I mentioned earlier, you can restart the BOT (not just the QE) to go back to the normal behavior, but this is not really a solution. |
I ran into the same issue on bitmex. I must confess, that I'm new to your project, but it seems, that K does always PONGs. |
thanks for insist on this; i can reproduce it as well in case someone wanna fix it, the issue must be all inside the single file src/bin/trading-bot/trading-bot.data.h otherwise i will attempt to find the solution soOn'' (cannot now cos i need to find myself first :S sorry) |
Maybe we can all work on this together to solve it, what do you suggest? should we create a group to communicate easier? |
finally this will be fixed at #1096 seems is because the quoting engine calculate safeties each second but orders can be filled faster, so a pong order can become a ping before the quoting engine notices it; cos an order is just filled and closed the last opened position so no more pongs really can exists (since pings are limited but pongs are freely done, this trade that really is now a ping will not be limited cos the quoting engine thinks that is a pong still) |
Strong debug skills |
Self explanatory, really.
The text was updated successfully, but these errors were encountered: