Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console log incorrectly reports all trades as PONG #1047

Closed
eniware-org opened this issue Jan 26, 2021 · 17 comments
Closed

Console log incorrectly reports all trades as PONG #1047

eniware-org opened this issue Jan 26, 2021 · 17 comments

Comments

@eniware-org
Copy link

Self explanatory, really.

@eniware-org

This comment has been minimized.

@eniware-org
Copy link
Author

Actually, there are PINGs, but only when the bot starts...
Maybe SellPing should be infinity, instead of 0.0000?

@eniware-org eniware-org reopened this Jan 28, 2021
@chefbc2k

This comment has been minimized.

@eniware-org

This comment has been minimized.

@ctubio
Copy link
Owner

ctubio commented Jan 29, 2021

im sorry maybe is cos is to late here but what means SellPing?

in any case having a value of 0 or infinity doesnt looks right to me.

@ctubio
Copy link
Owner

ctubio commented Feb 4, 2021

🐨 i cannot reproduce this, but let me know if you still want to reopen the issue :S

@ctubio ctubio closed this as completed Feb 4, 2021
@eniware-org
Copy link
Author

eniware-org commented Feb 13, 2021

Yes, it is still an issue. Have a look here:

image

... and in the console:

image

Here is on the SELL side:

image

As the QE is treating it as PONG, it also does not respect trades/sec protection. Also, The bot should only ping at BidSide, but fails to stop pinging at SellSide!!!

When I restart K.sh, things are back to normal!

Please, reopen this and let me know if you need any other information.

@eniware-org
Copy link
Author

So, here, after I restarted the bot all is fine until all pings are pong-ed. Then it always pongs:

image

image

@MiningInMySleep
Copy link

MiningInMySleep commented Mar 8, 2021

Any update on this? It's related to the issue described in this discussion thread: #1069

If the bot does not reliably ping/pong, strategies involving HFT are not viable (on boomerang?) because the bot will not reliably close positions (AKA take profit) when opportunities present themselves. There have been cases where K has pong'd itself into TBP held state with no actual pings available.

Once again, to illustrate my point, this should not happen with a pongWidth% of 0.001:
putty_2021-03-08_18-31-02
50017 -> 49537 is almost a 1% move and it wasn't registering a pong under boomerang.

@eniware-org
Copy link
Author

eniware-org commented Mar 8, 2021

@MiningInMySleep As I mentioned earlier, you can restart the BOT (not just the QE) to go back to the normal behavior, but this is not really a solution.
Just noticed that you are complaining about constant PINGs as I worry about constant PONGs - two opposite symptoms, but there must be the same reason and unfortunately - the same bad consequences.

@oorzkws
Copy link

oorzkws commented Mar 16, 2021

Ran into the same pong issue today, it has a pretty heavy effect on the trade logic.

edit: even after a few restarts, had left it for 4h and lost 5% on both sides.
image

edit 2: This has gotten significantly worse over the last few days.

@andy1245
Copy link

I ran into the same issue on bitmex. I must confess, that I'm new to your project, but it seems, that K does always PONGs.

@ctubio
Copy link
Owner

ctubio commented Mar 19, 2021

thanks for insist on this; i can reproduce it as well

in case someone wanna fix it, the issue must be all inside the single file src/bin/trading-bot/trading-bot.data.h

otherwise i will attempt to find the solution soOn'' (cannot now cos i need to find myself first :S sorry)

@Corfucinas
Copy link
Contributor

@ctubio

Maybe we can all work on this together to solve it, what do you suggest? should we create a group to communicate easier?

@ctubio
Copy link
Owner

ctubio commented Jul 11, 2021

finally this will be fixed at #1096

seems is because the quoting engine calculate safeties each second but orders can be filled faster, so a pong order can become a ping before the quoting engine notices it; cos an order is just filled and closed the last opened position so no more pongs really can exists (since pings are limited but pongs are freely done, this trade that really is now a ping will not be limited cos the quoting engine thinks that is a pong still)

@ctubio ctubio closed this as completed Jul 11, 2021
@Corfucinas
Copy link
Contributor

Strong debug skills

@ctubio
Copy link
Owner

ctubio commented Jul 12, 2021

source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants