Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LGTM code quality badges #90

Closed
wants to merge 1 commit into from
Closed

Add LGTM code quality badges #90

wants to merge 1 commit into from

Conversation

xcorail
Copy link

@xcorail xcorail commented Aug 31, 2018

Hi there!

I thought you might be interested in adding these code quality badges to your project. They will indicate a very high code quality to potential users and contributors.
You can also check the alerts discovered by LGTM.

N.B.: I am on the team behind LGTM.com, I'd appreciate your feedback on this initiative, whether you're interested or not, if you find time to drop me a line. Thanks.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 67.858% when pulling 0baf5e7 on xcorail:master into 72cccc4 on ctuning:master.

@xcorail
Copy link
Author

xcorail commented Aug 31, 2018

Is it expected that the coverage decreases when modifying only the README?

@gfursin
Copy link
Contributor

gfursin commented Nov 4, 2018

For now, we decided not to use extra badges, but we may re-consider it in the future.

@gfursin gfursin closed this Nov 4, 2018
@xcorail
Copy link
Author

xcorail commented Nov 5, 2018

Hello @gfursin
Thanks for this feedback.

Note that even if you don't put the badges, the LGTM alerts, and the automated code review will always be there for you.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants