Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify construction of AAD and Nonce values. #278

Merged
merged 3 commits into from
Jul 24, 2019

Conversation

briansmith
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 23, 2019

Coverage Status

Coverage decreased (-0.01%) to 96.512% when pulling 35f3615 on briansmith:b/simplify-aad into 666a2cb on ctz:master.

@codecov-io
Copy link

codecov-io commented Jul 24, 2019

Codecov Report

Merging #278 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   96.52%   96.51%   -0.02%     
==========================================
  Files          50       50              
  Lines        8318     8286      -32     
==========================================
- Hits         8029     7997      -32     
  Misses        289      289
Impacted Files Coverage Δ
src/key_schedule.rs 97.6% <100%> (-0.04%) ⬇️
src/cipher.rs 96.38% <100%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666a2cb...35f3615. Read the comment docs.

@briansmith briansmith changed the title Simplify construction of AAD. Simplify construction of AAD and Nonce values. Jul 24, 2019
@briansmith
Copy link
Contributor Author

Note: Instead of doing this nonce stuff, it would be straightforward to use OpeningKey and SealingKey with a custom NonceSequence implementation based on the make_tls13_nonce() I wrote here. However, my understanding is that you explicitly do prefer to use LessSafeKey instead, so I avoided including those changes here.

@ctz ctz merged commit 35f3615 into rustls:master Jul 24, 2019
@ctz
Copy link
Member

ctz commented Jul 24, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants