Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WriteV implementation for any Write objects #296

Merged
merged 1 commit into from Sep 4, 2019

Conversation

jpopesculian
Copy link
Contributor

Uses a write_vectored as a convenience function for implementing a WriteV adapter for any write object. It's a convenience function here, but I thought maybe this is food for thought in terms of changing write_tls to always use the write_vectored functionality if possible?

Adds a WriteVAdapter which takes a std::io::Write object and makes it
compatible with the WriteV trait
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.49% when pulling 2a3296e on jpopesculian:writev_impl into 2164246 on ctz:master.

@codecov-io
Copy link

codecov-io commented Sep 2, 2019

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files          50       50           
  Lines        8261     8261           
=======================================
  Hits         7971     7971           
  Misses        290      290
Impacted Files Coverage Δ
rustls/src/vecbuf.rs 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2164246...2a3296e. Read the comment docs.

@ctz ctz merged commit f022189 into rustls:master Sep 4, 2019
@ctz
Copy link
Member

ctz commented Sep 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants