Allows disabling of hostname verification. #64
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would allow a user to call:
danger_disable_host_name_verification
on a ClientConfig to disable host-name verification.I know this has been sort-of submitted as a PR before and rejected but I do think there are use cases for this and this tries to make it clear that there is a risk to doing this. A few things to consider:
My use case is building a tool that integrates with existing infrastructure, where in some cases the existing things are configured to use a cert that doesn't verify. I imagine this isn't an isolated case (hence all the other tools that support this), and as long as it's very clear what you're doing it's nice to support.