Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SCT parser for general use #2

Closed
wants to merge 1 commit into from
Closed

Conversation

kpcyrd
Copy link

@kpcyrd kpcyrd commented Jul 17, 2018

This allows access to the parser, as there is currently no way to get the metadata encoded inside an SCT. I've added documentation to everything that is public facing as required by #![deny(missing_docs)].

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 89.572% when pulling a6f255a on kpcyrd:pub into 9b67a54 on ctz:master.

@cpu
Copy link
Member

cpu commented Mar 3, 2023

I'm thinking that it might not make sense to inflate the API surface of this crate for general purpose SCT parsing and inspection. It looks like the x509-parser crate already exposes a SignedCertificateTimestap type and a function for parsing.

Would that API serve your purpose?

@cpu
Copy link
Member

cpu commented Mar 31, 2023

I'm going to close this PR since it looks like x509-parser will offer what you need. Thanks!

@cpu cpu closed this Mar 31, 2023
@kpcyrd kpcyrd deleted the pub branch April 3, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants