Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus on the function of <activity> element ? #81

Open
Nikhil-Ramachandran opened this issue Apr 21, 2017 · 6 comments
Open

consensus on the function of <activity> element ? #81

Nikhil-Ramachandran opened this issue Apr 21, 2017 · 6 comments

Comments

@Nikhil-Ramachandran
Copy link
Contributor

Nikhil-Ramachandran commented Apr 21, 2017

I know we haven't resolved this question.
I am not sure why "type" attribute has to be mandatory for "activity". Also, how have we decided to use "activity" within "block"?

testentry.dtd has the following definition for "activity", can we make "type" as not mandatory?

!ELEMENT activity (#PCDATA|activity|material)*
!ATTLIST activity
type NMTOKEN #REQUIRED

@bnhiebert
Copy link
Contributor

Seems to me that the "type" attribute serves a purpose in that it provides a way to designate activities as empty elements. Or is there good a way to include "activity" as an empty element while doing away with "type" attribute?

@Nikhil-Ramachandran
Copy link
Contributor Author

Nikhil-Ramachandran commented Apr 25, 2017

@bnhiebert Ben, I am still not sure how we are working with "purpose" at the "entry" level and "activity" at the "block" level. How are you using these elements? Could you suggest a couple of your entries as examples where "purpose" and "activity" are both used within an "entry"?

@bnhiebert
Copy link
Contributor

Actually I have been marking "activity" at the block level to comport with the schema, but I think you raise a good question: why are we, in fact, labeling "activity" at the block level but not "purpose"? I wonder if we might move activity up to the entry level since it's our main unit?

@Nikhil-Ramachandran
Copy link
Contributor Author

@bnhiebert Ben, that makes sense to me, especially if activity is a refinement of purpose. Wondering if others have any thoughts around this issue.
Can we change activity to an attribute of "entry" rather than "block"?

@tcatapano
Copy link
Member

I'll redefine the DTD for purpose and activity. Each will be:

  • available as children of <entry> and <block>
  • repeatable
  • have a required type attribute
  • may wrap text or be empty

@tcatapano
Copy link
Member

tcatapano commented Apr 26, 2017

Changed in DTD, some examples:

Empty, at beginning of <entry>:

<entry identifier="p009v_2">
    <folio number="009v" url="http://gallica.bnf.fr/ark:/12148/btv1b10500001g/f24.image"/>
      <activity type="accounting"/>
      <purpose type="observation"/>

Empty, at beginning of <block>:

<block>
        <activity type="accounting"/>
        <purpose type="observation"/> The order that merchants are accustomed to keep in their
        books, which are the waste book, the sales book, and the ledger, also called the account
        book.
    </block> 

Empty and wrapping text at beginning of <block>:

<block>
        <activity type="metalwork"/>
        <purpose type="observation">Because they often mix in with the ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants