Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev server needs cache control headers #21

Closed
camdendotlol opened this issue Aug 28, 2023 · 2 comments
Closed

Dev server needs cache control headers #21

camdendotlol opened this issue Aug 28, 2023 · 2 comments
Assignees

Comments

@camdendotlol
Copy link
Collaborator

camdendotlol commented Aug 28, 2023

While making frequent changes to the CLI app during development, I'm constantly being served old versions of the manifests after updating them. This is really getting in the way of development, because I have to fight with the server and with my browser to get the newly-updated files in the EditionCrafter frontend.

It appears that http-server needs to pass headers to tell browsers not to cache responses: https://stackoverflow.com/questions/38295463/node-http-server-not-serving-updated-html-files

Should be a simple fix, I'll do it in a separate branch when I'm finished with the annotation work.

@camdendotlol camdendotlol changed the title Dev server cache control headers are too Dev server needs cache control headers Aug 28, 2023
@camdendotlol camdendotlol self-assigned this Aug 28, 2023
@NickLaiacona
Copy link
Collaborator

NickLaiacona commented Sep 19, 2023

I see that this caching directive is now part of the start script in package.json:

"start": "node_modules/.bin/http-server -c-1 -p 8080 --cors"

Can we mark this as resolved?

@camdendotlol
Copy link
Collaborator Author

Yes, I ended up just putting the change in my most recent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants