Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance - Update SimpleSAML 1.18.x to 1.19.x #1

Open
alexfinnarn opened this issue Feb 18, 2022 · 5 comments
Open

Maintenance - Update SimpleSAML 1.18.x to 1.19.x #1

alexfinnarn opened this issue Feb 18, 2022 · 5 comments
Assignees

Comments

@alexfinnarn
Copy link
Collaborator

There is a known issues with CU's Federated Ping authentication and versions of the simpleSAMLphp library greater than 1.19.0. Until this is resolved, simpleSAMLphp is pinned to the 1.18.8 version.

I am updating the library for a D7 site and see that 1.18.8 is the safest version to use based on the wiki: https://github.com/cu-uis/cu-starterkit-project/wiki/SAML-Configuration

What exactly are the issues with CU's configuration? Looks like 2.0.0 is in the works as far as a target to update to https://github.com/simplesamlphp/simplesamlphp/releases?page=1

@kreynen
Copy link
Collaborator

kreynen commented Feb 22, 2022

There are more details about this in https://gitlab.cu.edu/ode/online-cu-starterkit/-/issues/71, but the gist is that one or more of the default values of the 1.19.x config files cause a failure with Chrome. The 1.19.x code with 1.18.x config worked, but explaining that a site building needed to first install 1.18.x and copy those configuration files before updating the code to 1.19.x was too confusing.

The real solution is to diff the configuration files and figure out which default setting change isn't compatible with CU's Ping configuration.

@kreynen kreynen changed the title SimpleSAML library update Update SimpleSAML 1.18.x to 1.19.x Feb 22, 2022
@kreynen
Copy link
Collaborator

kreynen commented Feb 24, 2022

  • Update the certs on existing sites using current SAML configuration
  • Update the code and configuration to 1.19.x
  • Confirm Chrome loopback issue still exists
  • Bisect the changes and new defaults to determine where the issue is
  • Work with IAM team to determine correct defaults

@kreynen kreynen changed the title Update SimpleSAML 1.18.x to 1.19.x Maintenance - Update SimpleSAML 1.18.x to 1.19.x Apr 11, 2022
@kreynen kreynen added the CU4CO label May 12, 2022
@kreynen kreynen self-assigned this May 17, 2022
@kreynen
Copy link
Collaborator

kreynen commented Aug 26, 2022

From https://simplesamlphp.org/...

2022-07-01: The first release candidate for SimpleSAMLphp 2.0 is available - Good
2022-07-01: SimpleSAMLphp 1.19.6 has been released - Good... .. should look at this since PHP8.0 support is really only supported in > 1.19.2 and PHP8.1 support requires > 1.19.4

2022-04-21: Job opening! SimpleSAMLphp lead maintainer. - Need to watch this as well as https://www.drupal.org/project/simplesamlphp_auth/issues/3303939

@alexfinnarn
Copy link
Collaborator Author

alexfinnarn commented Aug 26, 2022

https://www.drupal.org/docs/contributed-modules/saml-authentication/using-drupal-aswith-a-saml-sp has been updated recently, but it looks like they don't consider SimpleSAMLphp at all. Maybe time to switch?

...nevermind, it's mentioned, but I feel like they are saying it is more complicated/complex than using the other four modules.

@kreynen
Copy link
Collaborator

kreynen commented Aug 26, 2022

Pantheon is still recommending https://pantheon.io/docs/shibboleth-sso... not that they provided any support when dealing the the loopback in Chrome.

This is a bit of who takes the time to edit the Wikipedia determines what the facts are.

Screen Shot 2022-08-26 at 12 35 50 PM

You might recognize roderik form maintaining projects like https://www.drupal.org/project/samlauth

I don't love simpleSAMLphp, but it is the only library I actually have any experience with.

Looking at https://www.drupal.org/project/samlauth/issues/3289460, they aren't running the tests for samlauth against Drupal 10 or PHP8.1 yet.

Looking at https://www.drupal.org/project/simplesamlphp_auth/issues/3289683, Berdir already has tests passing against D10 and PHP8.1. He also responded to https://www.drupal.org/project/simplesamlphp_auth/issues/3306294 about the simpleSAMLphp 2.0-rc1 release...

Note that due to symfony compatibility, you will not be able to install 2.x on Drupal 9, just like you won't be able to install 1.x or 2.x on drupal 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants