Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider implementing Scroll to Text Fragment #11

Closed
cu opened this issue Oct 20, 2023 · 1 comment
Closed

consider implementing Scroll to Text Fragment #11

cu opened this issue Oct 20, 2023 · 1 comment

Comments

@cu
Copy link
Owner

cu commented Oct 20, 2023

Could be useful when coming to a page through the search results:

At this time, I'm not totally clear on how it works under the hood or if it's even useful for cases where a page contains dozens of results for a single search term. Possible it may only be used when the search query contains double quotes.

@cu
Copy link
Owner Author

cu commented May 23, 2024

Upon further investigation, I don't think this is helpful for us for the following reasons:

  1. There does not seem to be a way to restrict the fragment to a particular section of the page, e.g. within an <article> element. In Silicon, we have parts of the page (the sidebar, mainly) that should never be highlighted with a fragment and there does not seem to be any mechanism for avoiding that. And all of the workarounds for this that I can imagine are Very Complicated.
  2. Unless I'm just plain missing it, it doesn't look like text fragments will highlight multiple matches.
  3. Usage of it apparently requires the rel=noopener attribute on all links. For reasons that are not particularly clear.
  4. Everything about the design of Text Fragments seems to be specifically for Google's use case of sending the user directly to the snippet of text that they searched for when coming to a page via search engine results and no other use case. In other words, generalization of the feature for other use cases (especially text highlighting within the same page/app) seems to be an intentional and deliberate omission.

@cu cu closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant