Profile View #18
Profile View #18
Conversation
… natasha/categoriesFeed
changes removed the pods folder trying image view fixed pods made header view file worked more finished activity cell, added useractivity model finished cell, started header updated with colors changed colors started new designs for profile Started animation work on the header view. more animations done and the follow button completed Finished follow button, finished possible view animation Basically done with profile, needs cleanup almost finished. Cleaning up and changing cell to EpisodeTableViewCell Finished profile (for the most part). Will be changing the favorites cell ready to rebase
…podcast-ios into natasha/categoriesFeed
Natasha/categories feed
|
|
||
| // Main NavigationController initialization | ||
| let firstVC = FBSDKAccessToken.current() != nil ? tabBarController : loginVC | ||
| // let firstVC = tabBarController |
| ctx.strokePath() | ||
| ctx.restoreGState() | ||
|
|
||
| titleLabel?.textColor = (isSelected == true) ? UIColor.podcastWhite : UIColor.podcastBlack |
There was a problem hiding this comment.
only need isSelected instead of isSelected == true; also no UIColor
|
|
||
| override func draw(_ rect: CGRect) { | ||
| let ctx:CGContext = UIGraphicsGetCurrentContext()!; | ||
| let strokeColor: CGColor = self.tintColor.cgColor |
There was a problem hiding this comment.
no need for self here and in this file in general since without it, it would default to self
| ctx.setFillColor(fillColor) | ||
| ctx.setStrokeColor(strokeColor) | ||
| ctx.saveGState() | ||
| let lineWidth: CGFloat = 1.0; |
| } | ||
|
|
||
| override func draw(_ rect: CGRect) { | ||
| let ctx:CGContext = UIGraphicsGetCurrentContext()!; |
There was a problem hiding this comment.
space after colon and no semicolon
|
|
||
| titleLabel?.textColor = (isSelected == true) ? UIColor.podcastWhite : UIColor.podcastBlack | ||
|
|
||
| if (self.isSelected == false) { |
|
|
||
| if (self.isSelected == false) { | ||
| ctx.saveGState() | ||
| let fillPath: UIBezierPath = UIBezierPath(roundedRect: self.bounds.insetBy(dx: lineWidth, dy: lineWidth), byRoundingCorners: UIRectCorner.allCorners, cornerRadii: CGSize(width: self.bounds.size.height/2, height: self.bounds.size.height/2)) |
There was a problem hiding this comment.
no UIRectCorner; generally for enums, it's better to not include the prefix to keep it concise :)
| if let activity = activity { | ||
| let dateFormatter = DateFormatter() | ||
| dateFormatter.dateFormat = "eee, MMM dd" | ||
| // dateFormatter.timeStyle = .none |
There was a problem hiding this comment.
Remove all unnecessary comments in this file
| var actText = NSMutableAttributedString() | ||
| switch (activity.action) { | ||
| case .Liked: | ||
| actText = NSMutableAttributedString(string: "Liked "+podcastName) |
There was a problem hiding this comment.
I would store the string "Liked" in a separate variable and use it to get the location 6 for the NSRange in line 46, since it's subject to change
There was a problem hiding this comment.
Also string interpolation is your friend :) "Liked \(podcastName)"
| break | ||
| case .Listened: | ||
| actText = NSMutableAttributedString(string: "Listened to "+podcastName) | ||
| actText.addAttributes([NSForegroundColorAttributeName: UIColor.podcastPink, NSFontAttributeName: UIFont.boldSystemFont(ofSize: 14)], range: NSRange(location: 12, length:podcastName.characters.count)) |
| super.init(style: style, reuseIdentifier: reuseIdentifier) | ||
|
|
||
| frame.size.height = height+2*contentPaddingY | ||
| backgroundColor = UIColor.podcastWhite |
There was a problem hiding this comment.
remove UIColor and CGRect and other enum prefixes in this file
| containerView.frame = CGRect(x: contentPaddingX, y: contentPaddingY, width: cellSize.width-2*contentPaddingX, height: height) | ||
|
|
||
| let containSize = containerView.frame.size | ||
| let cellPadding:CGFloat = 12.0 |
There was a problem hiding this comment.
generally it's good to have a space after : when declaring types of variables for better readability
| // Currently: Followers, Following (Used to include subscriptions) | ||
| var bottomButton1: UIButton! | ||
| var bottomButton2: UIButton! | ||
| // var bottomButton3: UIButton! |
|
|
||
| // Currently: Followers, Following (Used to include subscriptions) | ||
| var bottomButton1: UIButton! | ||
| var bottomButton2: UIButton! |
There was a problem hiding this comment.
Let's rename bottomButton1 and bottomButton2 to names that are more representative or their action
There was a problem hiding this comment.
Right, I only did this because the design team hadn't decided on exactly what the buttons would be. They kept changing it so rather than renaming over and over again I just did this. But I can put it back now.
|
|
||
| profileImage.image = user.image | ||
| nameLabel.text = user.name | ||
| usernameLabel.text = "@"+user.username |
| override init(frame: CGRect) { | ||
| super.init(frame: frame) | ||
|
|
||
| self.backgroundColor = UIColor.podcastGrayDark |
There was a problem hiding this comment.
no self and enum prefixes in this file
| let proImgY: CGFloat = 28.5 | ||
| let padding: CGFloat = 12 | ||
| let labelHeight: CGFloat = 19 | ||
| let labelSpacing: CGFloat = 2.5 |
There was a problem hiding this comment.
Keep all constants at the top of the file
| profileImage.layer.cornerRadius = proImgWidth/2.0 | ||
| nameLabel.frame = CGRect(x: padding, y: proImgY+proImgWidth+padding, width: labelWidth, height: labelHeight) | ||
| usernameLabel.frame = CGRect(x: padding, y: usernameY, width: labelWidth, height: labelHeight) | ||
| followButton.frame = CGRect(x: (self.frame.size.width-150)/2, y: usernameY+labelHeight+padding, width: 150, height: 29) |
There was a problem hiding this comment.
seems like 150 and 29 should be declared as contants
|
|
||
| @objc func animateByYOffset(_ yOffset: CGFloat) { | ||
| let usernameY = proImgY+proImgWidth+padding+labelHeight+labelSpacing | ||
| print(yOffset) |
| print(yOffset) | ||
| if yOffset <= 0 { | ||
| profileImage.alpha = 1 | ||
| } else if yOffset >= (proImgY+proImgWidth/2) { |
There was a problem hiding this comment.
(proImgY+proImgWidth/2) is also used in line 195, so let's store it in a variable with a specific name so we know what this offset refers to
| paragraphStyle.alignment = .center | ||
|
|
||
| let numText = String(format: "%d", num) | ||
| let title = NSMutableAttributedString(string: text+"\n"+numText) |
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) { | ||
| print("Series pressed...") |
| guard let user = user else { return } | ||
| profileImage.image = user.image | ||
| nameLabel.text = user.name | ||
| usernameLabel.text = "@"+user.username |
| } | ||
| } | ||
|
|
||
| override init(frame: CGRect) { |
There was a problem hiding this comment.
no enum prefixes in file or self
|
|
||
| let profileSectionHeaderViewHeight: CGFloat = 37 | ||
|
|
||
| class ProfileSectionHeaderView: UIView { |
There was a problem hiding this comment.
no enum prefixes and self
| profileTableView.reloadData() | ||
| } | ||
|
|
||
| override func didReceiveMemoryWarning() { |
There was a problem hiding this comment.
we don't need this, so let's get rid of it for now
| miniHeader.setTopOpacity(0) | ||
| } else if yOffset >= PHVConstants.bottomBarDist-PHVConstants.miniHeight { | ||
| miniHeader.setTopOpacity(1) | ||
| } |
There was a problem hiding this comment.
condense lines 151 - 154:
let belowThreshold = (yOffset <= (PHVConstants.bottomBarDist-PHVConstants.miniHeight))
miniHeader.setTopOpacity(belowThreshold ? 0 : 1)
| return cell | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
not using storyboards, so don't need this
| super.init(frame: frame) | ||
| backgroundColor = UIColor.white | ||
|
|
||
| seriesImageView = UIImageView(frame: CGRect(x: 0, y: 0, width: frame.size.width, height: frame.size.height)) |
There was a problem hiding this comment.
don't need size for swift 3 anymore :) frame.width and frame.height should do
|
Made some comments! When you're done making those changes, commit them and I'll take another look :) |
changes removed the pods folder trying image view fixed pods made header view file worked more finished activity cell, added useractivity model finished cell, started header updated with colors changed colors started new designs for profile Started animation work on the header view. more animations done and the follow button completed Finished follow button, finished possible view animation Basically done with profile, needs cleanup almost finished. Cleaning up and changing cell to EpisodeTableViewCell Finished profile (for the most part). Will be changing the favorites cell ready to rebase
|
good to merge! |
|
Merged in b6305ac |
Created the profile view (for tab bar and as a profile detail). Still needs backend integration and once we figure out how our local data is stored will need an update. Design is apparently still working designs so it will need some color updates. Finally the Favorites tableviewcell has not been finalized and will need to be swapped out from the current DiscoverTableViewCell.