Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo profile to be a custom scroll view #200

Closed
doctor3w opened this issue Nov 6, 2017 · 8 comments
Closed

Redo profile to be a custom scroll view #200

doctor3w opened this issue Nov 6, 2017 · 8 comments
Assignees

Comments

@doctor3w
Copy link
Contributor

doctor3w commented Nov 6, 2017

Currently it's a table view with a cels that contain collection views and table views. This is bad. It's also the culprit of the weird space from dynamic cells.

@doctor3w
Copy link
Contributor Author

doctor3w commented Nov 6, 2017

This will also make profile header SnapKit compliant.

@doctor3w
Copy link
Contributor Author

doctor3w commented Nov 6, 2017

This will also add the null states for profile when a user has no subscriptions and no recommendations.

@natashaarmbrust
Copy link
Contributor

This should also fix the refresh the profile views when state changes ... i.e. if I unfollow a user this should reflect in my following count when I return to profile

@natashaarmbrust
Copy link
Contributor

img_6b17673f579b-1

@natashaarmbrust natashaarmbrust assigned jackthmp and unassigned doctor3w Feb 27, 2018
@natashaarmbrust
Copy link
Contributor

YAY newb now gets this issue .. @mindylou 's ScrollView / Discover branch should help you here so speak with her before implementing

@natashaarmbrust
Copy link
Contributor

Also the reason for this is that we dynamically resize the episode table view cells but have a set height for the tableview which is wrong

@natashaarmbrust natashaarmbrust assigned mindylou and unassigned jackthmp Mar 7, 2018
@natashaarmbrust
Copy link
Contributor

I'm assigning this to @mindylou

@natashaarmbrust
Copy link
Contributor

it would be great to have this done for tomorrow but obviously not necessary! depends how much time you have :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants