Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider applying primary style to button with primary action #36

Closed
web-devel opened this issue Jun 24, 2020 · 2 comments
Closed

Consider applying primary style to button with primary action #36

web-devel opened this issue Jun 24, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@web-devel
Copy link
Member

See action's primary attribute.

Steps to reproduce

  • set $cuba-highlight-primary-action:true;
  • wire button to primary action
    <actions>
        <action id="primaryAction" primary="true"/>
    </actions>
    <layout>
        <button action="primaryAction" caption="Button with primary action"/>
    </layout>

Button is not highlighted.
Also consider to set $cuba-highlight-primary-action to true by default in Helium.

@web-devel web-devel transferred this issue from cuba-platform/helium-theme-editor Jun 24, 2020
@web-devel web-devel added the enhancement New feature or request label Jun 24, 2020
@glebfox
Copy link
Member

glebfox commented Jun 25, 2020

Screenshot 2020-06-25 at 14 09 55

@glebfox
Copy link
Member

glebfox commented Jul 27, 2020

Related CUBA issue has been resolved: cuba-platform/cuba#2929.

@glebfox glebfox closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants