fix(playground): schemaVersion updates

cube-js · Nov 11, 2022 · 5c4880f · 5c4880f
1 parent 6ef8ce9
commit 5c4880f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/packages/cubejs-client-react/src/QueryBuilder.jsx b/packages/cubejs-client-react/src/QueryBuilder.jsx
@@ -31,7 +31,7 @@ const granularities = [
 
 export default class QueryBuilder extends React.Component {
   static contextType = CubeContext;
-  
+
   static defaultProps = {
     cubejsApi: null,
     stateChangeHeuristics: null,
@@ -42,7 +42,7 @@ export default class QueryBuilder extends React.Component {
     defaultQuery: {},
     initialVizState: null,
     onVizStateChanged: null,
-    
+
     // deprecated
     query: null,
     setQuery: null,
@@ -134,7 +134,6 @@ export default class QueryBuilder extends React.Component {
 
   async componentDidUpdate(prevProps) {
     const { schemaVersion, onSchemaChange } = this.props;
-    const { meta } = this.state;
 
     if (this.prevContext?.cubejsApi !== this.context?.cubejsApi) {
       this.prevContext = this.context;
@@ -143,8 +142,7 @@ export default class QueryBuilder extends React.Component {
 
     if (prevProps.schemaVersion !== schemaVersion) {
       try {
-        const newMeta = await this.cubejsApi().meta();
-        if (!equals(newMeta, meta) && typeof onSchemaChange === 'function') {
+        if (typeof onSchemaChange === 'function') {
           onSchemaChange({
             schemaVersion,
             refresh: async () => {
@@ -223,7 +221,7 @@ export default class QueryBuilder extends React.Component {
 
   prepareRenderProps(queryRendererProps) {
     const getName = (member) => member.name;
-    
+
     const toTimeDimension = (member) => {
       const rangeSelection = member.compareDateRange
         ? { compareDateRange: member.compareDateRange }
@@ -235,7 +233,7 @@ export default class QueryBuilder extends React.Component {
         ...rangeSelection,
       });
     };
-    
+
     const toFilter = (member) => ({
       member: member.member?.name || member.dimension?.name,
       operator: member.operator,

diff --git a/packages/cubejs-playground/src/components/PlaygroundQueryBuilder/QueryBuilderContainer.tsx b/packages/cubejs-playground/src/components/PlaygroundQueryBuilder/QueryBuilderContainer.tsx
@@ -73,8 +73,10 @@ export function QueryBuilderContainer(props: QueryBuilderContainerProps) {
               token={currentToken!}
               dashboardSource={props.dashboardSource}
               securityContextToken={securityContextToken}
-              onTabChange={props.onTabChange}
               extra={props.extra}
+              schemaVersion={props.schemaVersion}
+              onSchemaChange={props.onSchemaChange}
+              onTabChange={props.onTabChange}
               onVizStateChanged={props.onVizStateChanged}
               onSecurityContextModalOpen={() => setIsModalOpen(true)}
             />
@@ -105,7 +107,6 @@ function QueryTabsRenderer({
   token,
   securityContextToken,
   dashboardSource,
-  schemaVersion,
   onSecurityContextModalOpen,
   ...props
 }: QueryTabsRendererProps) {
@@ -158,8 +159,9 @@ function QueryTabsRenderer({
             chartType,
           }}
           dashboardSource={dashboardSource}
-          schemaVersion={schemaVersion}
+          schemaVersion={props.schemaVersion}
           extra={props.extra}
+          onSchemaChange={props.onSchemaChange}
           onVizStateChanged={(vizState) => {
             saveTab({
               query: vizState.query || {},