Skip to content

Commit

Permalink
fix(@cubejs-client/react): replace dimension with member (#2142)
Browse files Browse the repository at this point in the history
  • Loading branch information
vasilev-alex committed Feb 18, 2021
1 parent bca1ff7 commit 622f398
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/cubejs-client-react/src/QueryBuilder.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export default class QueryBuilder extends React.Component {
};
};
const toFilter = (member) => ({
dimension: member.dimension.name,
member: member.member?.name || member.dimension?.name,
operator: member.operator,
values: member.values,
});
Expand Down
4 changes: 2 additions & 2 deletions packages/cubejs-playground/src/QueryBuilder/FilterGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ const FilterGroup = ({

<Select
value={m.operator}
onChange={(operator) => updateMethods.update(m, { ...m, operator })}
style={{ width: 200 }}
onChange={(operator) => updateMethods.update(m, { ...m, operator })}
>
{m.operators.map((operator) => (
<Select.Option key={operator.name} value={operator.name}>
Expand All @@ -69,10 +69,10 @@ const FilterGroup = ({
);
})}
<MemberDropdown
onClick={(m) => updateMethods.add({ dimension: m })}
availableMembers={availableMembers}
type="dashed"
icon={<PlusOutlined />}
onClick={(m) => updateMethods.add({ member: m })}
>
{!members.length ? addMemberName : null}
</MemberDropdown>
Expand Down

0 comments on commit 622f398

Please sign in to comment.