Skip to content

Commit

Permalink
fix(client-ngx): client.ts is missing from the TypeScript compilation
Browse files Browse the repository at this point in the history
  • Loading branch information
paveltiunov committed Oct 1, 2019
1 parent b1b2f0f commit 65a30cf
Show file tree
Hide file tree
Showing 12 changed files with 4,561 additions and 35,431 deletions.
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"@babel/runtime-corejs2": "^7.0.0",
"core-js": "^2.5.3",
"ramda": "^0.25.0",
"rollup-plugin-dts": "^1.1.8",

This comment has been minimized.

Copy link
@Swatinem

Swatinem Oct 10, 2019

just wondering why this is in dependencies, even though its a dev dep per definition, and its not used anywhere :-D

This comment has been minimized.

Copy link
@paveltiunov

paveltiunov Oct 10, 2019

Author Member

@Swatinem Hey Arpad! Nice catch! Yep. It should be removed. I was trying to build angular client with rollup but without success.

"whatwg-fetch": "^3.0.0"
},
"files": [
Expand All @@ -33,11 +34,13 @@
"lerna": "^3.13.1",
"rollup": "^0.68",
"rollup-plugin-alias": "^1.4.0",
"rollup-plugin-angular": "^0.5.3",
"rollup-plugin-babel": "^4.0.3",
"rollup-plugin-commonjs": "^9.1.6",
"rollup-plugin-node-resolve": "^4.2.3",
"rollup-plugin-replace": "^2.0.0",
"rollup-plugin-typescript": "^1.0.1",
"rollup-plugin-typescript2": "^0.24.3",
"rollup-plugin-uglify": "^5.0.2",
"tslib": "^1.9.3",
"typescript": "^3.4.5"
Expand Down
23 changes: 23 additions & 0 deletions packages/cubejs-client-ngx/angular.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"$schema": "./node_modules/@angular/cli/lib/config/schema.json",
"version": 1,
"newProjectRoot": "projects",
"projects": {
"cubejs-client-ngx": {
"root": ".",
"sourceRoot": "src",
"projectType": "library",
"prefix": "ch",
"architect": {
"build": {
"builder": "@angular-devkit/build-ng-packagr:build",
"options": {
"tsConfig": "tsconfig.json",
"project": "ng-package.json"
}
}
}
}
},
"defaultProject": "cubejs-client-ngx"
}
105 changes: 0 additions & 105 deletions packages/cubejs-client-ngx/dist/cubejs-client-ngx.esm.js

This file was deleted.

109 changes: 0 additions & 109 deletions packages/cubejs-client-ngx/dist/cubejs-client-ngx.js

This file was deleted.

0 comments on commit 65a30cf

Please sign in to comment.