Skip to content

Commit

Permalink
fix: Empty data partitioned pre-aggregations are incorrectly handled …
Browse files Browse the repository at this point in the history
…-- value provided is not in a recognized RFC2822 or ISO format
  • Loading branch information
paveltiunov committed Oct 31, 2021
1 parent 8182824 commit 9f3acd5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 5 additions & 1 deletion packages/cubejs-backend-shared/src/time.ts
Expand Up @@ -85,7 +85,11 @@ export const utcToLocalTimeZone = (timezone: string, timestampFormat: string, ti

export const extractDate = (data: any): string => {
data = JSON.parse(JSON.stringify(data));
return moment.tz(data[0] && data[0][Object.keys(data[0])[0]], 'UTC').utc().format(moment.HTML5_FMT.DATETIME_LOCAL_MS);
const value = data[0] && data[0][Object.keys(data[0])[0]];
if (!value) {
return value;
}
return moment.tz(value, 'UTC').utc().format(moment.HTML5_FMT.DATETIME_LOCAL_MS);
};

export const addSecondsToLocalTimestamp = (timestamp: string, timezone: string, seconds: number): Date => {
Expand Down
Expand Up @@ -1189,6 +1189,9 @@ export class PreAggregationPartitionRangeLoader {

private async partitionRanges() {
const buildRange = await this.loadBuildRange();
if (!buildRange[0] || !buildRange[1]) {
return [];
}
let dateRange = PreAggregationPartitionRangeLoader.intersectDateRanges(
buildRange,
this.preAggregation.matchedTimeDimensionDateRange,
Expand Down

0 comments on commit 9f3acd5

Please sign in to comment.