Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(cubestore): create
metastore-current
atomically, do not send co…
…ntent-length to GCS This fixes at least one potential race: the cleanup loop in queue fs could delete the file while we were writing it. We also guard against potential errors better now. Note that any concurrent access to `metastore-current` can still result in inconsistent state. We do not know any particular instances where this happens, though. The GCS change does not affect correctness of uploads, but guards against potentially incorrect file sizes and make them more discoverable, e.g. there is now a slightly higher chance to get an error when reading the file.
- Loading branch information
1 parent
458b837
commit a2a68a0
Showing
3 changed files
with
26 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters