fix: More details for parsing errors during dashboard creation

cube-js · Jan 3, 2020 · a8cb9d3 · a8cb9d3
1 parent 7a7a3d2
commit a8cb9d3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 13 deletions.
diff --git a/packages/cubejs-server-core/dev/templates/SourceSnippet.js b/packages/cubejs-server-core/dev/templates/SourceSnippet.js
@@ -25,12 +25,16 @@ class SourceSnippet {
   }
 
   static parse(source) {
-    return parse(source, {
-      sourceType: 'module',
-      plugins: [
-        "jsx"
-      ]
-    });
+    try {
+      return parse(source, {
+        sourceType: 'module',
+        plugins: [
+          "jsx"
+        ]
+      });
+    } catch (e) {
+      throw new Error(`Can't parse source snippet: ${e.message}\n${source}`);
+    }
   }
 
   mergeImport(targetSource, importDeclaration) {

diff --git a/packages/cubejs-server-core/dev/templates/TargetSource.js b/packages/cubejs-server-core/dev/templates/TargetSource.js
@@ -10,13 +10,17 @@ class TargetSource {
   constructor(fileName, source) {
     this.source = source;
     this.fileName = fileName;
-    this.ast = parse(source, {
-      sourceFilename: fileName,
-      sourceType: 'module',
-      plugins: [
-        "jsx"
-      ]
-    });
+    try {
+      this.ast = parse(source, {
+        sourceFilename: fileName,
+        sourceType: 'module',
+        plugins: [
+          "jsx"
+        ]
+      });
+    } catch (e) {
+      throw new Error(`Can't parse ${fileName}: ${e.message}`);
+    }
     this.findAllImports();
     this.findAllDefinitions();
     this.findDefaultExport();