fix(@cubejs-client/core): pivot should work well with null values (#1386

). Thanks to @mspiegel31! * fix: 🐛 pivot should work well with null values * fix: removing timeDimensions from test data Co-authored-by: Mike Spiegel <mike@ripplescience.com>
cube-js · Nov 16, 2020 · d4c2446 · d4c2446
1 parent 1f37fb7
commit d4c2446
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 0 deletions.
diff --git a/packages/cubejs-client-core/src/ResultSet.js b/packages/cubejs-client-core/src/ResultSet.js
@@ -141,6 +141,11 @@ class ResultSet {
               range.end
             ].map((dt) => dt.format(moment.HTML5_FMT.DATETIME_LOCAL_MS)),
           });
+        } else if (value == null) {
+          filters.push({
+            member,
+            operator: 'notSet',
+          });
         } else {
           filters.push({
             member,

diff --git a/packages/cubejs-client-core/src/tests/drill-down.test.js b/packages/cubejs-client-core/src/tests/drill-down.test.js
@@ -80,6 +80,7 @@ const loadResponse = (query = {}) => ({
   },
 });
 
+
 describe('drill down query', () => {
   const resultSet1 = new ResultSet(loadResponse());
   const resultSet2 = new ResultSet(
@@ -98,6 +99,12 @@ describe('drill down query', () => {
       ],
     })
   );
+  const resultSet4 = new ResultSet(
+    loadResponse({
+      dimensions: ["Statuses.potential"],
+      timeDimensions: []
+    }
+  ))
 
   it('handles a query with a time dimension', () => {
     expect(
@@ -175,4 +182,32 @@ describe('drill down query', () => {
       timezone: 'UTC',
     });
   });
+
+
+  it('handles null values', () => {
+    expect(
+      resultSet4.drillDown({ xvalues: [null] })
+    ).toEqual(
+      {
+        measures: [],
+        dimensions: [
+          "Orders.id",
+          "Orders.title",
+        ],
+        filters: [
+          {
+            member: "Orders.count",
+            operator: "measureFilter",
+          },
+          {
+            member: "Statuses.potential",
+            operator: "notSet",
+          },
+        ],
+        timeDimensions: [],
+        timezone: "UTC",
+      }
+    )
+
+  })
 });