Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pivot should work well with null values #1386

Merged
merged 2 commits into from Nov 16, 2020

Conversation

mspiegel31
Copy link
Contributor

@mspiegel31 mspiegel31 commented Nov 14, 2020

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves
#1385

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@mspiegel31 mspiegel31 requested a review from a team as a code owner November 14, 2020 23:58
@rpaik rpaik added the pr:community Contribution from Cube.js community members. label Nov 16, 2020
@vasilev-alex vasilev-alex merged commit d4c2446 into cube-js:master Nov 16, 2020
vasilev-alex pushed a commit that referenced this pull request Dec 14, 2020
). Thanks to @mspiegel31!

* fix: 🐛 pivot should work well with null values

* fix: removing timeDimensions from test data

Co-authored-by: Mike Spiegel <mike@ripplescience.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants