feat(@cubejs-client/core): allow making HTTP POST requests to Cube.js API

[mnifakram]

Check List

• Tests has been run in packages where changes made if available
• Linter has been run for changed code
• Tests for the changes have been added if not covered yet
• Docs have been added / updated if required

Issue Reference this PR resolves

#1558

[mnifakram]

@hassankhan @ovr can you please guys review? Thanks.

[hassankhan]

@ovr Should we also be changing the default to POST too?

[vasilev-alex]

We should prefer the GET method whenever possible

[ovr]

100% agree with @vasilev-alex, it's better to use GET whenever possible.

[ovr]

@vasilev-alex @hassankhan Maybe it's better to set up it to undefined by default and detects automatically.

method = method || (url.length < 2000 ? 'GET' : 'POST')

[vasilev-alex]

@ovr yep, let's do like this. @mnifakram can you please introduce this check?

[mnifakram]

yes sure thing

[mnifakram]

@ovr @vasilev-alex I've just updated it. Please kindly check it. thanks

[vasilev-alex]

So, currently, I can see one limitation. It's not possible to change the method once we've created the cubejsApi instance.

const transport = new HttpTransport({
  // ...
  method: 'POST'
});

const cubejsApi = cubejs(CUBEJS_TOKEN, {
  apiUrl: `${API_URL}/cubejs-api/v1`,
  transport
});

// Can't change the `method` during runtime
// I want to send this one using `GET`
cubejsApi.load(query);
// and this one using `POST`
cubejsApi.load(query);

What if we would pass the HTTP method to the load?

cubejsApi.load(query, { method: 'GET' });
cubejsApi.load(query, { method: 'POST' });

Or, maybe, we could allow users to override the method by passing it to the load method? Do we even need it?

@ovr @hassankhan @mnifakram what do you think?

[mnifakram]

@vasilev-alex I don't think that users will switch between GET or POST, that's an edge case. In real world as a user if I didn't encounter the large URL problem and I only have POST, I will not even complain about not having GET as an option.

I don't see any advantages of using GET over POST. Not to mention that, it is way easier to inspect the query in the request body vs trying to decoded from the request URL.

[ovr]

I don't see any advantages of using GET over POST.

GET requests support cache inside browser, and possible Cube.js will return specific headers to support it.

[mnifakram]

Is there anything that I can help with to get this merged? I'm really in need to get this released asap. Thanks

[himessa]

Any update on this? I need the ability to handle large queries as well.