Improve support for the binary data type in cubestore #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow queries to return binary data. - support conversion from string and hexstring literals (e.g. X'deadbeef'). - fix errors when using binary type in computations. - add a simple test. This is a preparatory step for the upcoming HyperLogLog UDFs.
This matches MySQL behavior and is more practical.
github-actions
bot
added
the
pr:community
vasilev-alex
pushed a commit
that referenced
this pull request
Jan 15, 2021
* fix(cubestore): improve the binary type support - allow queries to return binary data. - support conversion from string and hexstring literals (e.g. X'deadbeef'). - fix errors when using binary type in computations. - add a simple test. This is a preparatory step for the upcoming HyperLogLog UDFs. * fix(cubestore): output binary values in hex encoding This matches MySQL behavior and is more practical.
vasilev-alex
pushed a commit
that referenced
this pull request
Jan 20, 2021
* fix(cubestore): improve the binary type support - allow queries to return binary data. - support conversion from string and hexstring literals (e.g. X'deadbeef'). - fix errors when using binary type in computations. - add a simple test. This is a preparatory step for the upcoming HyperLogLog UDFs. * fix(cubestore): output binary values in hex encoding This matches MySQL behavior and is more practical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for more info.
This fixes the crashes and errors I encountered while playing around with adding mock UDFs for HyperLogLog.