Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@cubejs-backend/api-gateway): readiness fix #1791

Merged
merged 2 commits into from
Jan 18, 2021
Merged

fix(@cubejs-backend/api-gateway): readiness fix #1791

merged 2 commits into from
Jan 18, 2021

Conversation

vasilev-alex
Copy link
Member

No description provided.

@vasilev-alex vasilev-alex requested a review from ovr January 15, 2021 13:59
@vasilev-alex vasilev-alex requested a review from a team as a code owner January 15, 2021 13:59
ovr
ovr approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I continue to think that it's not a good solution to add default data source, but LGTM for now because We don't have another solutions

@vasilev-alex vasilev-alex merged commit d5dad60 into master Jan 18, 2021
@vasilev-alex vasilev-alex deleted the readiness-fix branch January 18, 2021 10:04
vasilev-alex added a commit that referenced this pull request Jan 20, 2021
@vasilev-alex
fix(@cubejs-backend/api-gateway): readiness fix (#1791)
78ba5db 
* fix(@cubejs-backend/api-gateway): readiness fix

* test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovr ovr ovr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vasilev-alex @ovr