Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing features to vue package #194

Merged
merged 4 commits into from
Sep 5, 2019

Conversation

TCBroad
Copy link
Contributor

@TCBroad TCBroad commented Aug 30, 2019

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Fixes #32 (only for vue)
Fixes #188

Adds some missing features to the vue package to bring it more in line with the documentation:

  • Added support for measures in filters
  • Added support for limit
  • Added support for offset

I will add the remaining features in another PR as I didn't want this one to get too big

@TCBroad TCBroad changed the title Added missing feature to vue package Added missing features to vue package Aug 30, 2019
@paveltiunov
Copy link
Member

paveltiunov commented Aug 30, 2019

@TCBroad Hey Tom! Thanks for providing this! It's really great! The only thing: is dimension -> member change backward compatible?

@TCBroad
Copy link
Contributor Author

TCBroad commented Aug 31, 2019

Good point - it isn't at the moment. I could add the old property back in and check both if you feel this is a suitable way forward?

@paveltiunov
Copy link
Member

@TCBroad Yep. It would be great! Just revert changes to old tests and add checks for old properties with deprecated note. It would be enough. Thanks!

@paveltiunov
Copy link
Member

@TCBroad Hey Tom! Do you have time to fix that this week? We can merge and fix it on your behalf if you aren't available this week.

@TCBroad
Copy link
Contributor Author

TCBroad commented Sep 4, 2019

@paveltiunov yeah no problem. I should be able to push some stuff later, I have the changes locally

@paveltiunov
Copy link
Member

@TCBroad Looks great! Thanks for contributing this!

@paveltiunov paveltiunov merged commit 33f365a into cube-js:master Sep 5, 2019
@TCBroad TCBroad deleted the feature/fix-vue-filters branch September 5, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VueJs Client, limit not working Change dimension in the filter object in query to member
2 participants