fix(cubestore): return physical memory to the system at rest #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We seem to hit limitations of `malloc` from glibc, which causes physical memory to be retained by the allocator even after calls to `free`. Call `malloc_trim` on allocation-heavy operations to ensure we return freed memory to the system. See the comment in the code for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to hit limitations of
mallocfrom glibc, which causes physicalmemory to be retained by the allocator even after calls to
free.Call
malloc_trimon allocation-heavy operations to ensure we returnfreed memory to the system.
See the comment in the code for details.