Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@cubejs-client/react): type fixes #2140

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

vasilev-alex
Copy link
Member

Closes #2043

@vasilev-alex vasilev-alex requested a review from a team as a code owner February 18, 2021 13:42
Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Feb 18, 2021

Codecov Report

Merging #2140 (ace5840) into master (6bc0561) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2140   +/-   ##
=======================================
  Coverage   54.19%   54.19%           
=======================================
  Files         118      118           
  Lines        8598     8598           
  Branches     1884     1884           
=======================================
  Hits         4660     4660           
  Misses       3535     3535           
  Partials      403      403           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc0561...ace5840. Read the comment docs.

Copy link
Contributor

@hassankhan hassankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@vasilev-alex vasilev-alex merged commit bca1ff7 into master Feb 18, 2021
@vasilev-alex vasilev-alex deleted the react-types-fixes branch February 18, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryBuilderRenderProps documentation is missing some props or bug?
4 participants