Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(druid-driver): set valid sql timestamp #2151

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

adammruk
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Fix for #2149

Description of Changes Made (if issue reference is not provided)

Set valid SQL for current time.

@adammruk adammruk requested a review from a team as a code owner February 19, 2021 14:24
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #2151 (c146c53) into master (6bc0561) will increase coverage by 1.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2151      +/-   ##
==========================================
+ Coverage   54.19%   55.67%   +1.47%     
==========================================
  Files         118      118              
  Lines        8598     8598              
  Branches     1884     1884              
==========================================
+ Hits         4660     4787     +127     
+ Misses       3535     3432     -103     
+ Partials      403      379      -24     
Impacted Files Coverage Δ
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 50.97% <ø> (+3.44%) ⬆️
...ejs-schema-compiler/src/adapter/PreAggregations.js 23.79% <0.00%> (+1.20%) ⬆️
.../cubejs-schema-compiler/src/adapter/BaseMeasure.js 87.05% <0.00%> (+10.58%) ⬆️
...cubejs-schema-compiler/src/compiler/CubeSymbols.js 92.98% <0.00%> (+12.28%) ⬆️
...ubejs-schema-compiler/src/adapter/BaseDimension.js 79.41% <0.00%> (+35.29%) ⬆️
...s/cubejs-schema-compiler/src/compiler/JoinGraph.js 85.59% <0.00%> (+41.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b304e76...c146c53. Read the comment docs.

@ovr ovr merged commit 78a21d1 into cube-js:master Feb 19, 2021
@ovr
Copy link
Member

ovr commented Feb 19, 2021

Thank you @adammruk for your contribution 🍰 🍥

@rpaik rpaik added the bug Something isn't working label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants