feat: Support for elastic.co in ElasticsearchSriver and improved docs #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
Codecov Report
@@ Coverage Diff @@
## master #2240 +/- ##
==========================================
- Coverage 55.75% 55.68% -0.08%
==========================================
Files 118 118
Lines 8641 8643 +2
Branches 1888 1888
==========================================
- Hits 4818 4813 -5
- Misses 3444 3451 +7
Partials 379 379
Continue to review full report at Codecov.
|
ovr
reviewed
Mar 1, 2021
packages/cubejs-elasticsearch-driver/driver/ElasticSearchDriver.js
Outdated
Show resolved
Hide resolved
|
@hassankhan you probably want to take a look here with updates to docs 😄 |
hassankhan
suggested changes
Mar 2, 2021
There was a problem hiding this comment.
Thanks @kubarozkwitalski 🙌
Just had some minor nitpicks, if you wouldn't mind addressing them 😄
Co-authored-by: Hassan Khan <contact@hassankhan.me>
Co-authored-by: Hassan Khan <contact@hassankhan.me>
|
Hey @ovr , is there anything else I should do to get this merged? |
|
Thank you @kubarozkwitalski for your contribution 🍰 🥮 |
vasilev-alex
pushed a commit
that referenced
this pull request
Mar 23, 2021
) * feat: Support for elastic.co instances in Elasticsearch driver and improved docs. * code review fix * Update docs/content/Configuration/Environment-Variables-Reference.md Co-authored-by: Hassan Khan <contact@hassankhan.me> * Update packages/cubejs-elasticsearch-driver/README.md Co-authored-by: Hassan Khan <contact@hassankhan.me> * Update Environment-Variables-Reference.md add link Co-authored-by: Hassan Khan <contact@hassankhan.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
n/a
Description of Changes Made (if issue reference is not provided)
Added support for elastic.co-hosted instances of Elasticsearch. Not tested with opendistro nor native, non-hosted ES.