feat: Live preview watcher, refactor cube cloud package #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2418 +/- ##
=======================================
Coverage 56.35% 56.35%
=======================================
Files 118 118
Lines 8714 8714
Branches 1887 1887
=======================================
Hits 4911 4911
Misses 3437 3437
Partials 366 366 Continue to review full report at Codecov.
|
ovr
reviewed
Mar 23, 2021
| if (this.hooks.onStart) this.hooks.onStart(files); | ||
|
|
||
| try { | ||
| for (let i = 0; i < files.length; i++) { |
ovr
reviewed
Mar 23, 2021
ovr
reviewed
Mar 23, 2021
ovr
reviewed
Mar 23, 2021
ovr
reviewed
Mar 23, 2021
|
|
||
| if (!upstreamHashes[filePosix] || upstreamHashes[filePosix].hash !== fileHashes[file].hash) { | ||
| if (this.hooks.onUpload) this.hooks.onUpload(files, file); | ||
| await this.cubeCloudClient.uploadFile({ |
There was a problem hiding this comment.
Maybe it's better to use await Promise.all() WDYT?
ovr
reviewed
Mar 23, 2021
RusovDmitriy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]